Removed use of Refreshable and replaced with several methods which update the GUI using SwingUtilities.invokeLater().
While not as clean as using ChangeListener, it completely decouples the Model and View aspects, and also avoids the need to manually paint() a hierarchy of components (a task best handled by Swing/AWT).
This commit is contained in:
@@ -3,18 +3,17 @@ package view;
|
||||
import java.awt.GridLayout;
|
||||
import java.net.URL;
|
||||
|
||||
import javax.security.auth.Refreshable;
|
||||
import javax.swing.ImageIcon;
|
||||
import javax.swing.JLabel;
|
||||
import javax.swing.JPanel;
|
||||
import javax.swing.SwingUtilities;
|
||||
|
||||
import controller.BoardPanelMouseListener;
|
||||
|
||||
import model.Board;
|
||||
import model.Referee;
|
||||
|
||||
public class BoardPanel extends JPanel implements Refreshable {
|
||||
|
||||
public class BoardPanel extends JPanel {
|
||||
|
||||
public static final URL BLUE_ICON = BoardPanel.class
|
||||
.getResource("/img/blue.png");
|
||||
@@ -26,59 +25,58 @@ public class BoardPanel extends JPanel implements Refreshable {
|
||||
.getResource("/img/red.png");
|
||||
public static final URL YELLOW_ICON = BoardPanel.class
|
||||
.getResource("/img/yellow.png");
|
||||
|
||||
|
||||
private static final long serialVersionUID = 1L;
|
||||
|
||||
private final JLabel[][] board = new JLabel[Board.NUM_ROWS][Board.NUM_COLS];
|
||||
private final Referee referee;
|
||||
|
||||
public BoardPanel(Referee ref) {
|
||||
public BoardPanel(Referee ref, TileSelectionPanel tsp) {
|
||||
referee = ref;
|
||||
setLayout(new GridLayout(Board.NUM_ROWS, Board.NUM_COLS));
|
||||
|
||||
for (int r = 0; r < Board.NUM_ROWS; r++) {
|
||||
for (int c = 0; c < Board.NUM_COLS; c++) {
|
||||
board[r][c] = new JLabel(new ImageIcon(NONE_ICON));
|
||||
BoardPanelMouseListener bpml = new BoardPanelMouseListener(r, c, referee.getPlayer());
|
||||
|
||||
//separate listener on each JLabel? This should probably be changed.
|
||||
BoardPanelMouseListener bpml = new BoardPanelMouseListener(this, tsp, r,
|
||||
c, referee.getPlayer());
|
||||
|
||||
// separate listener on each JLabel? This should probably be
|
||||
// changed.
|
||||
board[r][c].addMouseListener(bpml);
|
||||
board[r][c].addMouseWheelListener(bpml);
|
||||
|
||||
|
||||
add(board[r][c]);
|
||||
}
|
||||
}
|
||||
|
||||
refresh();
|
||||
updateIcons();
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean isCurrent() {
|
||||
return true;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void refresh() {
|
||||
for (int r = 0; r < Board.NUM_ROWS; r++) {
|
||||
for (int c = 0; c < Board.NUM_COLS; c++) {
|
||||
switch (referee.getTile(r, c)) {
|
||||
case BLUE:
|
||||
board[r][c].setIcon(new ImageIcon(BLUE_ICON));
|
||||
break;
|
||||
case GREEN:
|
||||
board[r][c].setIcon(new ImageIcon(GREEN_ICON));
|
||||
break;
|
||||
case RED:
|
||||
board[r][c].setIcon(new ImageIcon(RED_ICON));
|
||||
break;
|
||||
case YELLOW:
|
||||
board[r][c].setIcon(new ImageIcon(YELLOW_ICON));
|
||||
break;
|
||||
default:
|
||||
board[r][c].setIcon(new ImageIcon(NONE_ICON));
|
||||
public void updateIcons() {
|
||||
SwingUtilities.invokeLater(new Runnable() {
|
||||
public void run() {
|
||||
for (int r = 0; r < Board.NUM_ROWS; r++) {
|
||||
for (int c = 0; c < Board.NUM_COLS; c++) {
|
||||
switch (referee.getTile(r, c)) {
|
||||
case BLUE:
|
||||
board[r][c].setIcon(new ImageIcon(BLUE_ICON));
|
||||
break;
|
||||
case GREEN:
|
||||
board[r][c].setIcon(new ImageIcon(GREEN_ICON));
|
||||
break;
|
||||
case RED:
|
||||
board[r][c].setIcon(new ImageIcon(RED_ICON));
|
||||
break;
|
||||
case YELLOW:
|
||||
board[r][c].setIcon(new ImageIcon(YELLOW_ICON));
|
||||
break;
|
||||
default:
|
||||
board[r][c].setIcon(new ImageIcon(NONE_ICON));
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
repaint();
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
@@ -3,26 +3,19 @@ package view;
|
||||
import java.awt.GridBagConstraints;
|
||||
import java.awt.GridBagLayout;
|
||||
import java.awt.Insets;
|
||||
import java.util.ArrayList;
|
||||
|
||||
import javax.security.auth.RefreshFailedException;
|
||||
import javax.security.auth.Refreshable;
|
||||
import javax.swing.JFrame;
|
||||
|
||||
import model.Referee;
|
||||
|
||||
public class MainFrame extends JFrame {
|
||||
/**
|
||||
*
|
||||
*/
|
||||
|
||||
private static final long serialVersionUID = 1L;
|
||||
|
||||
public static void main(String[] args) {
|
||||
new MainFrame();
|
||||
}
|
||||
|
||||
private final ArrayList<Refreshable> elements = new ArrayList<Refreshable>();
|
||||
|
||||
private final Referee game;
|
||||
|
||||
public MainFrame() {
|
||||
@@ -44,16 +37,10 @@ public class MainFrame extends JFrame {
|
||||
private void init() {
|
||||
// Create objects.
|
||||
ScorePanel sp = new ScorePanel(game);
|
||||
BoardPanel bp = new BoardPanel(game);
|
||||
MessagePanel mp = new MessagePanel(game);
|
||||
TileSelectionPanel tp = new TileSelectionPanel(game.getPlayer());
|
||||
|
||||
// Add refreshables.
|
||||
elements.add(sp);
|
||||
elements.add(bp);
|
||||
elements.add(mp);
|
||||
elements.add(tp);
|
||||
|
||||
BoardPanel bp = new BoardPanel(game,tp);
|
||||
MessagePanel mp = new MessagePanel(game);
|
||||
|
||||
// Add stuff to panel.
|
||||
GridBagLayout layout = new GridBagLayout();
|
||||
GridBagConstraints con;
|
||||
@@ -100,35 +87,14 @@ public class MainFrame extends JFrame {
|
||||
add(mp);
|
||||
add(bp);
|
||||
add(tp);
|
||||
}
|
||||
|
||||
private void refresh() {
|
||||
boolean change = false;
|
||||
|
||||
for (Refreshable r : elements) {
|
||||
|
||||
if (!game.isCurrent() || !r.isCurrent()) {
|
||||
try {
|
||||
r.refresh();
|
||||
change = true;
|
||||
} catch (RefreshFailedException e) {
|
||||
e.printStackTrace();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (change) {
|
||||
game.refresh();
|
||||
repaint();
|
||||
pack();
|
||||
}
|
||||
|
||||
pack();
|
||||
tp.updateBorders();
|
||||
}
|
||||
|
||||
private void run() {
|
||||
while (!game.isOver()) {
|
||||
game.doSomething();
|
||||
|
||||
refresh();
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -1,16 +1,13 @@
|
||||
package view;
|
||||
|
||||
import javax.security.auth.Refreshable;
|
||||
import javax.swing.JLabel;
|
||||
import javax.swing.JPanel;
|
||||
import javax.swing.SwingUtilities;
|
||||
|
||||
import model.Referee;
|
||||
|
||||
public class MessagePanel extends JPanel implements Refreshable {
|
||||
public class MessagePanel extends JPanel {
|
||||
|
||||
/**
|
||||
*
|
||||
*/
|
||||
private static final long serialVersionUID = 1L;
|
||||
|
||||
private final JLabel message = new JLabel();
|
||||
@@ -21,13 +18,11 @@ public class MessagePanel extends JPanel implements Refreshable {
|
||||
add(message);
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean isCurrent() {
|
||||
return true;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void refresh() {
|
||||
message.setText(referee.getMessage());
|
||||
public void updateMessage() {
|
||||
SwingUtilities.invokeLater(new Runnable() {
|
||||
public void run() {
|
||||
message.setText(referee.getMessage());
|
||||
}
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1,16 +1,13 @@
|
||||
package view;
|
||||
|
||||
import javax.security.auth.Refreshable;
|
||||
import javax.swing.JLabel;
|
||||
import javax.swing.JPanel;
|
||||
import javax.swing.SwingUtilities;
|
||||
|
||||
import model.Referee;
|
||||
|
||||
public class ScorePanel extends JPanel implements Refreshable {
|
||||
public class ScorePanel extends JPanel {
|
||||
|
||||
/**
|
||||
*
|
||||
*/
|
||||
private static final long serialVersionUID = 1L;
|
||||
|
||||
private final JLabel message = new JLabel();
|
||||
@@ -21,13 +18,11 @@ public class ScorePanel extends JPanel implements Refreshable {
|
||||
add(message);
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean isCurrent() {
|
||||
return true;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void refresh() {
|
||||
message.setText("Score: " + referee.getScore());
|
||||
public void updateScore() {
|
||||
SwingUtilities.invokeLater(new Runnable() {
|
||||
public void run() {
|
||||
message.setText("Score: " + referee.getScore());
|
||||
}
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
@@ -5,19 +5,18 @@ import java.awt.GridBagConstraints;
|
||||
import java.awt.GridBagLayout;
|
||||
import java.awt.Insets;
|
||||
|
||||
import javax.security.auth.RefreshFailedException;
|
||||
import javax.security.auth.Refreshable;
|
||||
import javax.swing.BorderFactory;
|
||||
import javax.swing.ImageIcon;
|
||||
import javax.swing.JLabel;
|
||||
import javax.swing.JPanel;
|
||||
import javax.swing.SwingUtilities;
|
||||
|
||||
import controller.PlayerController;
|
||||
import controller.TSPMouseListener;
|
||||
|
||||
import model.Board.TileColor;
|
||||
|
||||
public class TileSelectionPanel extends JPanel implements Refreshable {
|
||||
public class TileSelectionPanel extends JPanel {
|
||||
|
||||
private static final long serialVersionUID = 1L;
|
||||
|
||||
@@ -28,7 +27,7 @@ public class TileSelectionPanel extends JPanel implements Refreshable {
|
||||
private final JLabel yellow = new JLabel(new ImageIcon(
|
||||
BoardPanel.YELLOW_ICON));
|
||||
private final PlayerController pc;
|
||||
|
||||
|
||||
public TileSelectionPanel(PlayerController pc) {
|
||||
this.pc = pc;
|
||||
|
||||
@@ -36,40 +35,34 @@ public class TileSelectionPanel extends JPanel implements Refreshable {
|
||||
initActions();
|
||||
}
|
||||
|
||||
@Override
|
||||
public boolean isCurrent() {
|
||||
return pc.isCurrent();
|
||||
}
|
||||
|
||||
public void setCurrent(boolean current) {
|
||||
pc.setCurrent(current);
|
||||
}
|
||||
public void updateBorders() {
|
||||
SwingUtilities.invokeLater(new Runnable() {
|
||||
public void run() {
|
||||
TileColor tile = pc.getColor();
|
||||
|
||||
@Override
|
||||
public void refresh() throws RefreshFailedException {
|
||||
TileColor tile = pc.getColor();
|
||||
blue.setBorder(BorderFactory.createEmptyBorder(3, 3, 3, 3));
|
||||
green.setBorder(BorderFactory.createEmptyBorder(3, 3, 3, 3));
|
||||
red.setBorder(BorderFactory.createEmptyBorder(3, 3, 3, 3));
|
||||
yellow.setBorder(BorderFactory.createEmptyBorder(3, 3, 3, 3));
|
||||
|
||||
blue.setBorder(BorderFactory.createEmptyBorder(3, 3, 3, 3));
|
||||
green.setBorder(BorderFactory.createEmptyBorder(3, 3, 3, 3));
|
||||
red.setBorder(BorderFactory.createEmptyBorder(3, 3, 3, 3));
|
||||
yellow.setBorder(BorderFactory.createEmptyBorder(3, 3, 3, 3));
|
||||
|
||||
switch (tile) {
|
||||
case GREEN:
|
||||
green.setBorder(BorderFactory.createLineBorder(Color.RED, 3));
|
||||
break;
|
||||
case RED:
|
||||
red.setBorder(BorderFactory.createLineBorder(Color.RED, 3));
|
||||
break;
|
||||
case YELLOW:
|
||||
yellow.setBorder(BorderFactory.createLineBorder(Color.RED, 3));
|
||||
break;
|
||||
default:
|
||||
blue.setBorder(BorderFactory.createLineBorder(Color.RED, 3));
|
||||
break;
|
||||
}
|
||||
|
||||
pc.setCurrent(true);
|
||||
switch (tile) {
|
||||
case GREEN:
|
||||
green.setBorder(BorderFactory
|
||||
.createLineBorder(Color.RED, 3));
|
||||
break;
|
||||
case RED:
|
||||
red.setBorder(BorderFactory.createLineBorder(Color.RED, 3));
|
||||
break;
|
||||
case YELLOW:
|
||||
yellow.setBorder(BorderFactory.createLineBorder(Color.RED,
|
||||
3));
|
||||
break;
|
||||
default:
|
||||
blue.setBorder(BorderFactory.createLineBorder(Color.RED, 3));
|
||||
break;
|
||||
}
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
private void initActions() {
|
||||
|
||||
Reference in New Issue
Block a user